refactor(cli): improve error handling for remote script fetch#1408
Merged
antongolub merged 1 commit intogoogle:mainfrom Feb 22, 2026
Merged
refactor(cli): improve error handling for remote script fetch#1408antongolub merged 1 commit intogoogle:mainfrom
antongolub merged 1 commit intogoogle:mainfrom
Conversation
ce5d957 to
f45a92e
Compare
Collaborator
|
We'd like to avoid bloating comments, so the current try-catches are fine. But the explicit error related to |
Contributor
Author
|
@antongolub Thanks for the feedback! Scoped the PR to only the |
Collaborator
|
Follow the PR template hints:
|
Contributor
Author
|
@antongolub Updated — bundle rebuilt and added assertions to the existing |
antongolub
approved these changes
Feb 22, 2026
Replace abrupt process.exit(1) in readScriptFromHttp with process.exitCode = 1 + throw new Fail(...) for consistent error handling with the rest of the codebase. Ref google#1394
cf6289b to
7356a0d
Compare
antongolub
approved these changes
Feb 22, 2026
Contributor
Author
|
@antongolub Squashed everything into a single clean commit rebased on latest |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #1394
npm buildbefore committing and verified the bundle updates correctly.testand confirmed all tests succeed.