This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Conversation
dhermes
approved these changes
Jan 30, 2017
Contributor
dhermes
left a comment
dhermes
left a comment
There was a problem hiding this comment.
LGTM if Travis can actually run py36?
Contributor
Author
|
It can run Waiting on grpc/grpc#9445 |
dhermes
reviewed
Jan 30, 2017
| echo 'Extracting secrets.' | ||
| scripts/decrypt-secrets.sh "$SECRETS_PASSWORD" | ||
| # Prevent build failures from leaking our password. | ||
| # looking at you, Tox. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Still LGTM, pending the wheel |
Contributor
Author
Thanks. :) |
Contributor
Author
|
PyLint doesn't yet work on 3.6, so we're going to hold that env back to 3.5 |
Contributor
Author
|
Thanks.
…On Wed, Mar 1, 2017 at 1:54 PM Florian Bruhin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In scripts/travis.sh
<#102 (comment)>
:
> @@ -25,6 +25,9 @@ if [[ -n $SYSTEM_TEST ]]; then
if [[ $TRAVIS_SECURE_ENV_VARS == "true" ]]; then
echo 'Extracting secrets.'
scripts/decrypt-secrets.sh "$SECRETS_PASSWORD"
+ # Prevent build failures from leaking our password.
+ # looking at you, Tox.
Ouch... I opened tox-dev/tox#466
<tox-dev/tox#466> about that.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#102 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUczXVbWjBCXA237yhTDrXtpsZt_hmks5rhej_gaJpZM4LxvHf>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.