This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Create abstract Verifier and Signer, remove key_id hack from App Engine and IAM signers#115
Merged
Create abstract Verifier and Signer, remove key_id hack from App Engine and IAM signers#115
Conversation
…ne and IAM signers
dhermes
reviewed
Feb 18, 2017
| to :attr:`key_id` and :meth:`sign`. This could result in a signature | ||
| that was signed with a different key than the one indicated by | ||
| :attr:`key_id`. It's recommended that if you use this in your code | ||
| that you account for this behavior by building in retry logic. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google/auth/crypt.py
Outdated
|
|
||
|
|
||
| class RSASigner(Signer): | ||
| """Signs messages with a RSA private key. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google/auth/crypt.py
Outdated
| def __init__(self, private_key, key_id=None): | ||
| self._key = private_key | ||
| self._key_id = key_id | ||
| """""" |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
LGTM? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #112