This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Fix gRPC to call credentials.before_request#116
Merged
Conversation
dhermes
approved these changes
Feb 18, 2017
| # call works. | ||
| list_topics_iter = client.list_topics( | ||
| project='projects/{}'.format(project_id)) | ||
| list(list_topics_iter) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
lukesneeringer
approved these changes
Feb 21, 2017
lukesneeringer
left a comment
lukesneeringer
left a comment
There was a problem hiding this comment.
It is a little odd to me that neither system test actually asserts anything.
Contributor
Author
They do assert something, they assert the absence of an exception. The return value of the pubsub test could be an empty list. However, if the auth code fails (doesn't inject the header, injects the wrong header, etc.) then an exception will be raised. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #113