Remove one-time token behavior of JWT Credentials by theacodes · Pull Request #117 · googleapis/google-auth-library-python

theacodes · 2017-02-22T23:19:19Z

Resolves #114

google/auth/jwt.py

        credentials = jwt.Credentials.from_service_account_file(
-            'service-account.json')
+            'service-account.json',
+            audience='https://speech.googleapis.com')


google/auth/jwt.py

    """

-    def __init__(self, signer, issuer=None, subject=None, audience=None,
+    def __init__(self, signer, issuer, subject, audience,


google/auth/jwt.py

+        kwargs.setdefault('issuer', info['client_email'])
+        return cls(
+            signer,
+            **kwargs)


google/auth/jwt.py

-            audience (str): the `aud` claim. If not specified, a new
-                JWT will be generated for every request and will use
-                the request URI as the audience.
+            audience (str): the `aud` claim. If unspecified the current


google/auth/jwt.py

        # (pylint doesn't correctly recognize overridden methods.)
        self.token, self.expiry = self._make_jwt()

+    @_helpers.copy_docstring(credentials.Signing)


google/auth/jwt.py

    def signer(self):
        return self._signer
-
-    def before_request(self, request, method, url, headers):


google/oauth2/service_account.py

                'service_account.json')

+        Args:
+            audience (str): the `aud` claim. The intended audience for the


dhermes · 2017-02-23T00:51:55Z

We good?

theacodes · 2017-02-23T00:58:27Z

@dhermes if you're good & travis is good then I'm good.

dhermes · 2017-02-23T02:48:37Z

Seems you gotta fix CI but LGTM otherwise

Remove one-time token behavior of JWT Credentials

4cc94e8

theacodes requested review from dhermes and lukesneeringer February 22, 2017 23:19

dhermes reviewed Feb 22, 2017

View reviewed changes

Fix system test

9c4c754

Jon Wayne Parrott added 2 commits February 23, 2017 08:35

Fix system test

5a76279

Fix system test

f8a7d4d

theacodes merged commit ab08689 into master Feb 23, 2017

theacodes deleted the jwt-credential-audience branch February 23, 2017 17:20

Conversation

theacodes commented Feb 22, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Feb 23, 2017

Uh oh!

theacodes commented Feb 23, 2017

Uh oh!

dhermes commented Feb 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants