Add service_account.Credentials.with_claims by theacodes · Pull Request #140 · googleapis/google-auth-library-python

theacodes · 2017-03-22T22:26:04Z

Resolves #129.

google/auth/jwt.py

        Returns:
            google.auth.jwt.Credentials: A new credentials instance.
        """
+        new_additional_claims = self._additional_claims.copy()


google/auth/jwt.py

            google.auth.jwt.Credentials: A new credentials instance.
        """
+        new_additional_claims = self._additional_claims.copy()
+        new_additional_claims.update(additional_claims or {})


google/oauth2/service_account.py

            subject=subject,
            additional_claims=self._additional_claims.copy())

+    def with_claims(self, additional_claims):


dhermes · 2017-03-23T17:17:02Z

LGTM I suppose. It seems you want to eat the teeny cost of or {} every time, so it's all good?

theacodes · 2017-03-23T17:57:59Z

It seems you want to eat the teeny cost of or {} every time, so it's all good?

The cost of that vs. the cost of copy/deepcopy is insignificant.

I'm going to update this to use deepcopy, but I'm finishing something else up first. Thanks for the review!

Add service_account.Credentials.with_claims

f89dbf2

theacodes requested review from dhermes and lukesneeringer March 22, 2017 22:26

dhermes reviewed Mar 23, 2017

View reviewed changes

Use deepcopy

fbeab71

theacodes merged commit 75c78b2 into master Mar 23, 2017

theacodes deleted the service-account-claims branch March 23, 2017 20:14

Conversation

theacodes commented Mar 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented Mar 23, 2017

Uh oh!

theacodes commented Mar 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

theacodes commented Mar 22, 2017 •

edited

Loading