This repository was archived by the owner on Mar 6, 2026. It is now read-only.
Improve documentation around ID Tokens#224
Merged
theacodes merged 2 commits intogoogleapis:masterfrom Feb 8, 2018
Merged
Conversation
theacodes
suggested changes
Nov 29, 2017
Contributor
theacodes
left a comment
theacodes
left a comment
There was a problem hiding this comment.
Mostly LGTM and thanks for doing this!
google/oauth2/id_token.py
Outdated
| """Google ID Token helpers.""" | ||
| """Google ID Token helpers. | ||
|
|
||
| Provides support for verifying OAuth 2.0 ID Tokens, especially ones generated |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google/oauth2/id_token.py
Outdated
| from google.auth.transport import requests | ||
|
|
||
| request = requests.Request() | ||
| try: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google/oauth2/id_token.py
Outdated
|
|
||
| request = requests.Request() | ||
| try: | ||
| id_info = id_token.verify_oauth2_token(token, request, CLIENT_ID) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
google/oauth2/id_token.py
Outdated
|
|
||
| from google.auth.transport import requests | ||
|
|
||
| sess = session() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
theacodes
approved these changes
Feb 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes a section on how to do caching, as part of #218 .
I've never used Sphinx for documentation before, and suggestions on clearer/more precise wording are always appreciated