Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

Use cls parameter instead of class#341

Merged
busunkim96 merged 1 commit intogoogleapis:masterfrom
emilecaron:patch-1
Jul 25, 2019
Merged

Use cls parameter instead of class#341
busunkim96 merged 1 commit intogoogleapis:masterfrom
emilecaron:patch-1

Conversation

@emilecaron
Copy link
Contributor

Use cls parameter instead of explicit Credentials reference to allow subclassing

Use cls parameter instead of explicit `Credentials` reference to allow subclassing
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 9, 2019
@emilecaron
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 9, 2019
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label May 16, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jul 3, 2019
@busunkim96 busunkim96 merged commit 530f5f9 into googleapis:master Jul 25, 2019
@emilecaron emilecaron deleted the patch-1 branch July 26, 2019 15:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants