Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

setup.py: set an upper bound on dependencies version#352

Merged
busunkim96 merged 1 commit intogoogleapis:masterfrom
JordanP:master
Jul 16, 2019
Merged

setup.py: set an upper bound on dependencies version#352
busunkim96 merged 1 commit intogoogleapis:masterfrom
JordanP:master

Conversation

@JordanP
Copy link
Contributor

@JordanP JordanP commented Jul 16, 2019

This should make this library more robust in case of breaking changes in one of
its dependencies.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 16, 2019
@JordanP
Copy link
Contributor Author

JordanP commented Jul 16, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 16, 2019
@JordanP
Copy link
Contributor Author

JordanP commented Jul 16, 2019

CI failed because it's now running with pytest version 5 released a few days ago and it introduced breaking changes... I guess that proves the point of setting an upper bound :)

This should make this library more robust in case of breaking changes in one of
its dependencies.
@busunkim96 busunkim96 self-requested a review July 16, 2019 23:29
Copy link
Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @JordanP!

@busunkim96 busunkim96 merged commit 38166b2 into googleapis:master Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants