This repository was archived by the owner on Mar 6, 2026. It is now read-only.
setup.py: set an upper bound on dependencies version#352
Merged
busunkim96 merged 1 commit intogoogleapis:masterfrom Jul 16, 2019
JordanP:master
Merged
setup.py: set an upper bound on dependencies version#352busunkim96 merged 1 commit intogoogleapis:masterfrom JordanP:master
busunkim96 merged 1 commit intogoogleapis:masterfrom
JordanP:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
CI failed because it's now running with pytest version 5 released a few days ago and it introduced breaking changes... I guess that proves the point of setting an upper bound :) |
This should make this library more robust in case of breaking changes in one of its dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should make this library more robust in case of breaking changes in one of
its dependencies.