Add requests transport by theacodes · Pull Request #66 · googleapis/google-auth-library-python

theacodes · 2016-10-31T19:47:23Z

No description provided.

…sed in system tests.

docs/conf.py

    'python': ('https://docs.python.org/3.5', None),
-    'urllib3': ('https://urllib3.readthedocs.io/en/latest', None),
+    'urllib3': ('https://urllib3.readthedocs.io/en/stable', None),
+    'requests': ('http://docs.python-requests.org/en/stable', None),


google/auth/transport/requests.py

+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+"""Transport adapter for Requests."""


system_tests/conftest.py

-HTTP = urllib3.PoolManager(retries=False)
+URLLIB3_HTTP = urllib3.PoolManager(retries=False)
+REQUESTS_SESSION = requests.Session()
+REQUESTS_SESSION.verify = False


system_tests/conftest.py

-@pytest.fixture
-def http_request():
+@pytest.fixture(params=['urllib3', 'requests'])
+def http_request(request):


tests/transport/test_requests.py

+        assert http.request.call_args[1]['timeout'] == 5
+
+
+class MockCredentials(object):


tox.ini

  pytest-localserver
  urllib3
  certifi
+  requests


tests/transport/test_requests.py

+        assert mock_credentials.before_request.called
+        assert not mock_credentials.refresh.called
+        assert mock_adapter.requests[0].url == self.TEST_URL
+        assert mock_adapter.requests[0].headers['authorization'] == 'token'


Add requests transport

be7b0fa

theacodes added this to the 1.0.0 milestone Oct 31, 2016

theacodes assigned dhermes Oct 31, 2016

Jon Wayne Parrott added 2 commits October 31, 2016 12:53

Parametrize http_request so that both urllib3 and requests are exerci…

0467114

…sed in system tests.

Disable certification verification

322bdb8

dhermes approved these changes Oct 31, 2016

View reviewed changes

Assert requests length

a47574c

theacodes merged commit 9a9ce2c into master Oct 31, 2016

theacodes deleted the requests-transport branch October 31, 2016 21:59

theacodes unassigned dhermes Oct 11, 2018

		assert http.request.call_args[1]['timeout'] == 5


		class MockCredentials(object):

Conversation

theacodes commented Oct 31, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants