feat(storage/transfermanager): checksum full object downloads#10569
Merged
BrennaEpp merged 4 commits intogoogleapis:mainfrom Jul 30, 2024
Merged
feat(storage/transfermanager): checksum full object downloads#10569BrennaEpp merged 4 commits intogoogleapis:mainfrom
BrennaEpp merged 4 commits intogoogleapis:mainfrom
Conversation
product-auto-label
bot
added
the
api: storage
tritone
reviewed
Jul 24, 2024
Contributor
tritone
left a comment
tritone
left a comment
There was a problem hiding this comment.
In general looks really good, a few minor questions/comments. Also, could you add a note to the docs to indicate under what circumstances checksumming will be performed?
|
|
||
| // maxChecksumZeroArraySize is the maximum amount of memory to allocate for | ||
| // updating the checksum. A larger size will occupy more memory but will require | ||
| // more updates when computing the crc32c of a full object. |
Contributor
There was a problem hiding this comment.
This seems wrong, I would imagine larger means fewer updates?
Contributor
Author
There was a problem hiding this comment.
Correct, I messed up that wording.
|
|
||
| // joinCRC32C pieces together the initial checksum with the orderedChecksums | ||
| // provided to calculate the checksum of the whole. | ||
| func joinCRC32C(initialChecksum uint32, orderedChecksums []crc32cPiece) uint32 { |
Contributor
There was a problem hiding this comment.
It seems surprising that this isn't available in hash/crc32 or elsewhere in a standard library, but I assume you looked.
Contributor
Author
There was a problem hiding this comment.
Yeah, there was a feature request for it a while back but they considered it not common enough a use-case to include in the standard library: golang/go#12297
tritone
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.