Skip to content

Comments

feat(auth): auth library can talk to S2A over mTLS#10634

Merged
quartzmo merged 3 commits intogoogleapis:mainfrom
xmenxk:mtls-to-s2a
Aug 15, 2024
Merged

feat(auth): auth library can talk to S2A over mTLS#10634
quartzmo merged 3 commits intogoogleapis:mainfrom
xmenxk:mtls-to-s2a

Conversation

@xmenxk
Copy link
Contributor

@xmenxk xmenxk commented Aug 2, 2024

Talking to the secure session agent(s2a) requires mTLS on GCE/GKE, and also serverless in the future. This PR adds the functionality to load the mTLS credentials from disk and use that to talk to s2a.

Also removed the refresh logic for s2a configuration. We decided to only request it from MDS on first use and cache it afterwards.

@xmenxk xmenxk requested a review from a team August 2, 2024 23:42
@quartzmo
Copy link
Member

Please update your branch, thanks!

@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 14, 2024
@quartzmo quartzmo enabled auto-merge (squash) August 15, 2024 17:43
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 15, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 15, 2024
@quartzmo quartzmo merged commit 5250a13 into googleapis:main Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants