-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Release the world to support 'client_info' for manual clients. #7968
Copy link
Copy link
Closed
Labels
api: bigqueryIssues related to the BigQuery API.Issues related to the BigQuery API.api: bigquerystorageIssues related to the BigQuery Storage API.Issues related to the BigQuery Storage API.api: bigtableIssues related to the Bigtable API.Issues related to the Bigtable API.api: clouderrorreportingIssues related to the Error Reporting API.Issues related to the Error Reporting API.api: cloudresourcemanagerIssues related to the Resource Manager API.Issues related to the Resource Manager API.api: cloudtraceIssues related to the Cloud Trace API.Issues related to the Cloud Trace API.api: datastoreIssues related to the Datastore API.Issues related to the Datastore API.api: dnsIssues related to the Cloud DNS API.Issues related to the Cloud DNS API.api: firestoreIssues related to the Firestore API.Issues related to the Firestore API.api: loggingIssues related to the Cloud Logging API.Issues related to the Cloud Logging API.api: pubsubIssues related to the Pub/Sub API.Issues related to the Pub/Sub API.api: runtimeconfigIssues related to the Cloud Runtime Config API API.Issues related to the Cloud Runtime Config API API.api: spannerIssues related to the Spanner API.Issues related to the Spanner API.api: translationIssues related to the Cloud Translation API API.Issues related to the Cloud Translation API API.packagingtype: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.
Metadata
Metadata
Assignees
Labels
api: bigqueryIssues related to the BigQuery API.Issues related to the BigQuery API.api: bigquerystorageIssues related to the BigQuery Storage API.Issues related to the BigQuery Storage API.api: bigtableIssues related to the Bigtable API.Issues related to the Bigtable API.api: clouderrorreportingIssues related to the Error Reporting API.Issues related to the Error Reporting API.api: cloudresourcemanagerIssues related to the Resource Manager API.Issues related to the Resource Manager API.api: cloudtraceIssues related to the Cloud Trace API.Issues related to the Cloud Trace API.api: datastoreIssues related to the Datastore API.Issues related to the Datastore API.api: dnsIssues related to the Cloud DNS API.Issues related to the Cloud DNS API.api: firestoreIssues related to the Firestore API.Issues related to the Firestore API.api: loggingIssues related to the Cloud Logging API.Issues related to the Cloud Logging API.api: pubsubIssues related to the Pub/Sub API.Issues related to the Pub/Sub API.api: runtimeconfigIssues related to the Cloud Runtime Config API API.Issues related to the Cloud Runtime Config API API.api: spannerIssues related to the Spanner API.Issues related to the Spanner API.api: translationIssues related to the Cloud Translation API API.Issues related to the Cloud Translation API API.packagingtype: processA process-related concern. May include testing, release, or the like.A process-related concern. May include testing, release, or the like.
/cc @crwilcox, @busunkim96, @tswast
Follow-on to #7825. Because we are releasing new features in
google-api-coreand (more importantly)google-cloud-core, we need to handle this release phase delicately. Current clients which depend ongoogle-cloud-coreuse a too-narrow pin:Per conversation today, we plan to go ahead and release a
1.0.0ofgoogle-cloud-core. Before that, we need to make releases from the last tags of the clients above which broaden the range togoogle-cloud-core >= 0.29.0, < 2.0dev.Prep Releases
For each of the following:
bigquery(BigQuery: Widen range for 'google-cloud-core'. #7969)bigtable(Bigtable: Widen range for 'google-cloud-core'. #7970)datastore(Datastore: Widen range for 'google-cloud-core'. #7971)dns(DNS: Widen range for 'google-cloud-core'. #7972)firestore(Firestore: Widen range for 'google-cloud-core'. #7973)logging(Logging: Widen range for 'google-cloud-core'. #7974)resource_manager(Resource Manager: Widen range for 'google-cloud-core'. #7975)runtimeconfig(Runtimeconfig: Widen range for 'google-cloud-core'. #7976)spanner(Spanner: Widen range for 'google-cloud-core'. #7977)storage(Storage: Widen range for 'google-cloud-core'. #7978)trace(Trace: Widen range for 'google-cloud-core'. #7979)translate(Translate: Widen range for 'google-cloud-core'. #7980)the procedure is:
$ git checkout -b bigquery-1.11-back bigquery-1.11.2.$ git push upstream bigquery-1.11-back.$ git checkout -b bigquery-1.11.3-release bigquery-1.11-back.setup.pytogoogle-cloud-core >= 0.29.0, < 2.0dev.$ git commit setup.py -m "Widen range for 'google-cloud-core'."-releasebranch, e.g.$ git push origin bigquery-1.11.3-release.-releasebranch, targeting the-backbranch.autorelease-pending.setup.pyto bump the version, e.g. to1.11.3.CHANGELOG.mdto include the widening and PR #.originbranch.$ git checkout bigquery-1.11-back && git fetch upstream && git merge upstream/bigquery-1.11-back.$ git tag bigquery-1.11.3$ git push upstream bigquery-1.11.3.Core Releases
Once all the prep releases are finished, use
releasetoolto make new releases of core packages:api_core-1.11.0(Release api_core 1.11.0 #7985)core/setup.pyto pingoogle-api-core >= 1.11.0, < 2.0dev. (Core: update dep on 'api_core' >= 1.11.0. #7986)core-1.0.0(Release core 1.0.0 #7990)Update Client Library Pins
Once the new
google-api-coreandgoogle-cloud-corereleases are complete, create PRs for each client frommasterwhich bump the pins for each one accordingly to match:bigquery(Omnibus: pin new core 1.0.0 #7993)bigtable(Omnibus: pin new core 1.0.0 #7993)datastore(Omnibus: pin new core 1.0.0 #7993)dns(Omnibus: pin new core 1.0.0 #7993)error_reportingnot needed, it doesn't directly depend ongoogle-api-core/google-cloud-corefirestore(Omnibus: pin new core 1.0.0 #7993)logging(Omnibus: pin new core 1.0.0 #7993)resource_manager(Omnibus: pin new core 1.0.0 #7993)runtimeconfig(Omnibus: pin new core 1.0.0 #7993)spanner(Omnibus: pin new core 1.0.0 #7993)storage(Omnibus: pin new core 1.0.0 #7993)trace(Omnibus: pin new core 1.0.0 #7993)translate(Omnibus: pin new core 1.0.0 #7993)Client Library Releases
After merging the "update pins" PRs, run
releasetoolfor each manual client, and shepherd out the releases:bigquery(Release bigquery 1.12.0 #8001)bigtable(Release bigtable 0.33.0 #8002)datastoredoes not yet haveclient_infosupport! See issue Datastore: add 'client_info' argument to client ctor. #8003.dns(Release dns 0.30.0 #8004)firestore(Release firestore 1.2.0 #8005)logging(Release logging 1.11.0 #8006)resource_manager(Release resource_manager 0.29.0 #8007)runtimeconfig(Release runtimeconfig 0.29.0 #8008)spanner(Release spanner 1.9.0 #8009)storage(Release storage 1.16.0 #8010)trace(Release trace 0.21.0 #8011)translate(Release translate 1.5.0 #8012)Because
error_reportingrelies on transitive deps ofgoogle-cloud-loggingto pick up newgoogle-api-coreandgoogle-cloud-coreversions, it has to be handled specially:google-cloud-logging >= 1.11.0. (Error Reporting: pin 'google-cloud-logging >= 1.11.0'. #8015)Datastore:
client_infofeature. (Datastore: Addclient_infosupport to client. #8013)