Skip to content

chore: librarian generate pull request: 20260311T085726Z#16065

Merged
parthea merged 1 commit intomainfrom
librarian-20260311T085726Z
Mar 11, 2026
Merged

chore: librarian generate pull request: 20260311T085726Z#16065
parthea merged 1 commit intomainfrom
librarian-20260311T085726Z

Conversation

@cloud-sdk-librarian-robot
Copy link
Copy Markdown
Collaborator

@cloud-sdk-librarian-robot cloud-sdk-librarian-robot commented Mar 11, 2026

PR created by the Librarian CLI to generate Cloud Client Libraries code from protos.

BEGIN_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for message DestintionEnum is changed

PiperOrigin-RevId: 881702559
Library-IDs: google-shopping-type
Source-link: googleapis/googleapis@6df3ecf4
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: add more values in DestintionEnum

PiperOrigin-RevId: 881702559
Library-IDs: google-shopping-type
Source-link: googleapis/googleapis@6df3ecf4
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: upgrade protobuf from v25.7 to v31.0

PiperOrigin-RevId: 881595129
Library-IDs: google-cloud-gdchardwaremanagement,google-cloud-gke-hub,google-maps-routing
Source-link: googleapis/googleapis@d90d23fa
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: add ParameterizedSecureViewParameters message and field for PSV support

PiperOrigin-RevId: 881451746
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@9807038c
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: update field comments for generated_looker_query in DataMessage

PiperOrigin-RevId: 881451746
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@9807038c
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: add ThinkingMode enum and field to control agent thinking mode

PiperOrigin-RevId: 881451746
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@9807038c
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: update field comments for generated_looker_query in DataMessage

PiperOrigin-RevId: 881447800
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b8457412
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: add ParameterizedSecureViewParameters message and field for PSV support

PiperOrigin-RevId: 881447800
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b8457412
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: add ThinkingMode enum and field to control agent thinking mode

PiperOrigin-RevId: 881447800
Library-IDs: google-cloud-geminidataanalytics
Source-link: googleapis/googleapis@b8457412
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: regenerated documentation for fields

PiperOrigin-RevId: 879699007
Library-IDs: google-maps-routing
Source-link: googleapis/googleapis@67b11682
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: add a new Waypoint source to accept a token that identifies a Navigation Point obtained from the SearchDestinations method of the Geocoding API

PiperOrigin-RevId: 879699007
Library-IDs: google-maps-routing
Source-link: googleapis/googleapis@67b11682
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: Add OFFLINE state to Zone resources
A new OFFLINE state has been added to the Zone.State enum. This state indicates that the zone is temporarily not operational, for example, while undergoing maintenance or repair

PiperOrigin-RevId: 879057351
Library-IDs: google-cloud-gdchardwaremanagement
Source-link: googleapis/googleapis@40a49dc1
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
chore: remove empty extra_opts from the C# proto library

PiperOrigin-RevId: 878469306
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@63b4dff9
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: feat: update advertiser_identifier_count in PairIdInfo to be optional

PiperOrigin-RevId: 878469306
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@63b4dff9
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: deprecate INVALID_COUNTRY_CODE and add MEMBERSHIP_DURATION_TOO_LONG to the ErrorReason enum

PiperOrigin-RevId: 878469306
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@63b4dff9
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: update publisher_name in PairIdInfo to be required

PiperOrigin-RevId: 878469306
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@63b4dff9
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: update filter field documentation to clarify case requirements and improve examples

PiperOrigin-RevId: 878469306
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@63b4dff9
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: update match_rate_percentage in PairIdInfo to be required

PiperOrigin-RevId: 878469306
Library-IDs: google-ads-datamanager
Source-link: googleapis/googleapis@63b4dff9
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: An existing field app is renamed to name in message .google.cloud.ces.v1beta.UploadEvaluationAudioRequest

PiperOrigin-RevId:
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@1fa95b7e
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: An existing field audio_transcript is renamed to transcript in message .google.cloud.ces.v1beta.UploadEvaluationAudioResponse

PiperOrigin-RevId:
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@1fa95b7e
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: An existing field audio_duration is renamed to duration in message .google.cloud.ces.v1beta.UploadEvaluationAudioResponse

PiperOrigin-RevId:
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@1fa95b7e
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
feat: update public libraries for CES v1beta

PiperOrigin-RevId:
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@1fa95b7e
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field cert in message .google.cloud.ces.v1beta.TlsConfig is changed

PiperOrigin-RevId:
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@1fa95b7e
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: An existing field variables is moved in to oneof in message .google.cloud.ces.v1beta.ExecuteToolRequest

PiperOrigin-RevId:
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@1fa95b7e
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: An existing method_signature app,audio_content is removed from method UploadEvaluationAudio in service EvaluationService

PiperOrigin-RevId:
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@1fa95b7e
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
fix: An existing google.api.http annotation http_uri is changed for method UploadEvaluationAudio in service EvaluationService

PiperOrigin-RevId:
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@1fa95b7e
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field name in message .google.cloud.ces.v1beta.Tool is changed PiperOrigin-RevId: 878047537

PiperOrigin-RevId:
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@1fa95b7e
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: A comment for field entry_agent in message .google.cloud.ces.v1beta.SessionConfig is changed

PiperOrigin-RevId:
Library-IDs: google-cloud-ces
Source-link: googleapis/googleapis@1fa95b7e
END_NESTED_COMMIT

END_COMMIT

This pull request is generated with proto changes between
googleapis/googleapis@8f70147e
(exclusive) and
googleapis/googleapis@6df3ecf4
(inclusive).

Librarian Version: v0.0.0-20260216162532-e323d455c92b
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:160860d189ff1c2f7515638478823712fa5b243e27ccc33a2728669fa1e2ed0c

Generation failed for

  • google-cloud-compute
  • google-cloud-compute-v1beta
  • google-cloud-dialogflow
  • google-cloud-dialogflow-cx
  • google-cloud-discoveryengine
  • google-cloud-pubsub
  • google-cloud-retail
  • google-shopping-merchant-accounts

@cloud-sdk-librarian-robot
Copy link
Copy Markdown
Collaborator Author

cloud-sdk-librarian-robot commented Mar 11, 2026

One or more libraries have failed to generate, please review PR description for a list of failed libraries.
For each failed library, open a ticket in that library’s repository and then you may resolve this comment and merge.

@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Mar 11, 2026

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 11, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the generation of Cloud Client Libraries code from updated protocol buffer definitions. It includes feature additions, documentation improvements, and bug fixes across a range of Google Cloud and Maps APIs, with a focus on enhancing security settings and data management capabilities.

Highlights

  • Proto Updates: This PR incorporates several proto updates, including feature additions, documentation updates, and bug fixes across multiple Google Cloud and Maps APIs.
  • Library Generation: The Librarian CLI generated this PR to update Cloud Client Libraries code from protos, affecting various libraries such as google-ads-datamanager, google-maps-routing, and google-cloud-ces.
  • CES API Changes: Significant changes are introduced to the google-cloud-ces library, including the addition of security settings, updates to method signatures, and field renames to enhance the API's functionality and clarity.
  • Ads Data Manager API Updates: The google-ads-datamanager library receives updates to its error handling and data structures, including deprecating INVALID_COUNTRY_CODE and adding MEMBERSHIP_DURATION_TOO_LONG to the ErrorReason enum.
Changelog
  • google-cloud-compute
    • Generation failed for this library.
  • google-cloud-dialogflow
    • Generation failed for this library.
  • google-cloud-retail
    • Generation failed for this library.
  • google-shopping-merchant-accounts
    • Generation failed for this library.
Activity
  • The pull request was created by the Librarian CLI to generate Cloud Client Libraries code from protos.
  • The PR includes several nested commits with features, fixes, and documentation updates.
  • Generation failed for google-cloud-compute, google-cloud-dialogflow, google-cloud-retail, and google-shopping-merchant-accounts.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 11, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request primarily updates last_generated_commit hashes across many Google Cloud libraries. Specific code changes include deprecating an enum and adding a new one in google-ads-datamanager/error.py, along with clarifying field descriptions and correcting the optionality of advertiser_identifier_count in google-ads-datamanager/user_list.py. For google-cloud-ces, new SecuritySettings and AgentTool types were introduced, and a bug was fixed where UploadEvaluationAudioRequest incorrectly used app instead of name for routing. Further updates include adding an OFFLINE state in google-cloud-gdchardwaremanagement, introducing ParameterizedSecureViewParameters and ThinkingMode in google-cloud-geminidataanalytics, and refining documentation for various fields and adding new enum values in google-maps-routing and google-shopping-type.

packages/google-ads-datamanager/google/ads/datamanager_v1/types/error.py
Comment on lines 63 to +64
INVALID_COUNTRY_CODE (13):
Country code is not valid.
Deprecated: Enum is unused in the Data
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The comment for INVALID_COUNTRY_CODE should accurately reflect that the enum is deprecated and unused.

Suggested change
INVALID_COUNTRY_CODE (13):
Country code is not valid.
Deprecated: Enum is unused in the Data
Deprecated: Enum is unused in the Data
Manager API.

packages/google-ads-datamanager/google/ads/datamanager_v1/types/user_list.py
Comment on lines 571 to 574
publisher_name (str):
Optional. Descriptive name of the publisher
Required. Descriptive name of the publisher
to be displayed in the UI for a better targeting
experience.
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The publisher_name field should be marked as required in the description.

Suggested change
publisher_name (str):
Optional. Descriptive name of the publisher
Required. Descriptive name of the publisher
to be displayed in the UI for a better targeting
experience.
Required. Descriptive name of the publisher
to be displayed in the UI for a better targeting
experience.

packages/google-ads-datamanager/google/ads/datamanager_v1/types/user_list.py
Comment on lines +583 to +586
This field is a member of `oneof`_ ``_match_rate_percentage``.
advertiser_identifier_count (int):
Output only. The count of the advertiser's
first party data records that have been uploaded
to a clean room provider. This does not signify
the size of a PAIR user list.
Optional. The count of the advertiser's first
party data records that have been uploaded to a
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The advertiser_identifier_count field should be marked as optional in the description.

Suggested change
This field is a member of `oneof`_ ``_match_rate_percentage``.
advertiser_identifier_count (int):
Output only. The count of the advertiser's
first party data records that have been uploaded
to a clean room provider. This does not signify
the size of a PAIR user list.
Optional. The count of the advertiser's first
party data records that have been uploaded to a
Optional. The count of the advertiser's first
party data records that have been uploaded to a
clean room provider. This does not signify the
size of a PAIR user list.

packages/google-ads-datamanager/google/ads/datamanager_v1/types/user_list.py
Comment on lines 610 to 612
match_rate_percentage: int = proto.Field(
proto.INT32,
number=3,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The advertiser_identifier_count field should be optional.

        number=4,
        optional=True,

packages/google-cloud-ces/google/cloud/ces_v1beta/services/evaluation_service/async_client.py
# request, apply these.
if app is not None:
request.app = app
if name is not None:
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The request should use name instead of app.

Suggested change
if name is not None:
request.name = name

packages/google-cloud-ces/google/cloud/ces_v1beta/services/evaluation_service/client.py
if app is not None:
request.app = app
if name is not None:
request.name = name
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The request should use name instead of app.

Suggested change
request.name = name
if name is not None:
request.name = name

@parthea parthea merged commit 207c72a into main Mar 11, 2026
26 of 27 checks passed
@parthea parthea deleted the librarian-20260311T085726Z branch March 11, 2026 09:30
@parthea parthea mentioned this pull request Mar 11, 2026
Closed
@parthea
Copy link
Copy Markdown
Contributor

parthea commented Mar 11, 2026

Filed #16066 to follow up on the failed generation for

google-cloud-compute
google-cloud-compute-v1beta
google-cloud-dialogflow
google-cloud-dialogflow-cx
google-cloud-discoveryengine
google-cloud-pubsub
google-cloud-retail
google-shopping-merchant-accounts

The docs failure is a known issue and tracked in #15655

This was referenced Mar 12, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cloud-sdk-librarian-robot @parthea