Skip to content

Spanner: unflake 'test_update_database_ddl #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tseaver wants to merge 2 commits into from
Closed

Spanner: unflake 'test_update_database_ddl #5697

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e138ea
Avoid reusing temporary db names across systests.
tseaver Jul 27, 2018
5d71a08
Bump timout for 'update_database_ddl'.
tseaver Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spanner/tests/system/test_system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ def test_list_databases(self):

def test_create_database(self):
pool = BurstyPool()
temp_db_id = 'temp_db' + unique_resource_id('_')
temp_db_id = 'create_db' + unique_resource_id('_')
temp_db = Config.INSTANCE.database(temp_db_id, pool=pool)
operation = temp_db.create()
self.to_delete.append(temp_db)
Expand All @@ -277,7 +277,7 @@ def test_create_database(self):
self.assertIn(temp_db_id, database_ids)

def test_table_not_found(self):
temp_db_id = 'temp_db' + unique_resource_id('_')
temp_db_id = 'table_404' + unique_resource_id('_')

correct_table = 'MyTable'
incorrect_table = 'NotMyTable'
Expand Down Expand Up @@ -306,7 +306,7 @@ def test_table_not_found(self):

def test_update_database_ddl(self):
pool = BurstyPool()
temp_db_id = 'temp_db' + unique_resource_id('_')
temp_db_id = 'update_db' + unique_resource_id('_')
temp_db = Config.INSTANCE.database(temp_db_id, pool=pool)
create_op = temp_db.create()
self.to_delete.append(temp_db)
Expand All @@ -317,7 +317,7 @@ def test_update_database_ddl(self):
operation = temp_db.update_ddl(DDL_STATEMENTS)

# We want to make sure the operation completes.
operation.result(120) # raises on failure / timeout.
operation.result(150) # raises on failure / timeout.

temp_db.reload()

Expand Down