Skip to content

feat(pubsub): add APIs to shutdown subscriber#5257

Merged
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:feat-pubsub-subscriber-shutdown
Apr 3, 2026
Merged

feat(pubsub): add APIs to shutdown subscriber#5257
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:feat-pubsub-subscriber-shutdown

Conversation

@dbolduc
Copy link
Copy Markdown
Member

@dbolduc dbolduc commented Apr 3, 2026

Most of the work for #5024 (the rest are cleanups)

Provide a way for applications to both signal and await a shutdown of a subscriber message stream.


Docs look like:

Screenshot From 2026-04-03 12-52-40 Screenshot From 2026-04-03 12-54-36

@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the Pub/Sub API. label Apr 3, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.98%. Comparing base (c295557) to head (54c485d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5257   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         215      215           
  Lines       44904    44904           
=======================================
  Hits        43999    43999           
  Misses        905      905           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc marked this pull request as ready for review April 3, 2026 17:13
@dbolduc dbolduc requested a review from a team as a code owner April 3, 2026 17:13
Copy link
Copy Markdown
Contributor

@suzmue suzmue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: PR title description

The PR title could be more descriptive about what this PR is actually doing. maybe "feat(pubsub): make subscriber shutdown public with documentation" or something

There are two PRs that have the same title (minus type) which makes it harder to browse the history to identify which PRs are responsible for what.

@dbolduc dbolduc changed the title feat(pubsub): subscriber shutdown feat(pubsub): add APIs to shutdown subscriber Apr 3, 2026
@dbolduc
Copy link
Copy Markdown
Member Author

dbolduc commented Apr 3, 2026

nit: PR title

Fixed.

@dbolduc dbolduc merged commit 8cc7ac3 into googleapis:main Apr 3, 2026
36 checks passed
@dbolduc dbolduc deleted the feat-pubsub-subscriber-shutdown branch April 3, 2026 18:55
@dbolduc dbolduc mentioned this pull request Apr 3, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants