feat(pubsub): add APIs to shutdown subscriber#5257
Merged
dbolduc merged 1 commit intogoogleapis:mainfrom Apr 3, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5257 +/- ##
=======================================
Coverage 97.98% 97.98%
=======================================
Files 215 215
Lines 44904 44904
=======================================
Hits 43999 43999
Misses 905 905 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
suzmue
approved these changes
Apr 3, 2026
Contributor
suzmue
left a comment
There was a problem hiding this comment.
nit: PR title description
The PR title could be more descriptive about what this PR is actually doing. maybe "feat(pubsub): make subscriber shutdown public with documentation" or something
There are two PRs that have the same title (minus type) which makes it harder to browse the history to identify which PRs are responsible for what.
Member
Author
Fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the work for #5024 (the rest are cleanups)
Provide a way for applications to both signal and await a shutdown of a subscriber message stream.
Docs look like: