Parsing JSON with unknown Enum

[vtcosta]

Parsing JSON with unknown Enum will raise a NullPointerException:

Exception in thread "main" java.lang.NullPointerException
    at com.google.api.client.util.Data.parsePrimitiveValue(Data.java:440)
    at com.google.api.client.json.JsonParser.parseValue(JsonParser.java:850)
    at com.google.api.client.json.JsonParser.parse(JsonParser.java:471)
    at com.google.api.client.json.JsonParser.parseValue(JsonParser.java:780)
    at com.google.api.client.json.JsonParser.parse(JsonParser.java:471)
    at com.google.api.client.json.JsonParser.parseValue(JsonParser.java:780)
    at com.google.api.client.json.JsonParser.parse(JsonParser.java:381)
    at com.google.api.client.json.JsonParser.parse(JsonParser.java:354)
    at com.google.api.client.json.JsonObjectParser.parseAndClose(JsonObjectParser.java:87)
    at com.google.api.client.json.JsonObjectParser.parseAndClose(JsonObjectParser.java:81)
    at com.google.api.client.http.HttpResponse.parseAs(HttpResponse.java:459)

It would be nice for that Enum property to be null when an unknown string is parsed, than to not being able to parse an object, and receive a NullPointerException.

[ejona86]

At the very least, it should be a better error.

[elharo]

Without breaking the API, this could throw a subclass of IOException.

Anyone have a sample unit test that demonstrates this problem?

[andrey-qlogic]

@vtcosta , @elharo
The issue looks outdated.
Checking the stringValue parameter for null in

google-http-java-client/google-http-client/src/main/java/com/google/api/client/util/Data.java

Line 406 in b466220

if (stringValue == null || primitiveClass == null

,

and throwing an IllegalArgumentException if the enum is unknown

google-http-java-client/google-http-client/src/main/java/com/google/api/client/util/Data.java

Line 449 in b466220

throw new IllegalArgumentException(String.format("given enum name %s not part of " +

[andrey-qlogic]

@sduskis, reopened until PR with unit test for unknown enum merged.