Add abstract JSON test and tests for Jackson2 and gson #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
3 tasks
chingor13
force-pushed
the
json-parser-test
branch
from
9c0dd15 to
3f68b06
Compare
chingor13
force-pushed
the
json-parser-test
branch
from
3f68b06 to
da2afa1
Compare
sduskis
approved these changes
Jun 3, 2019
| import java.nio.charset.StandardCharsets; | ||
| import junit.framework.TestCase; | ||
|
|
||
| public abstract class AbstractJsonParserTest extends TestCase { |
Contributor
There was a problem hiding this comment.
This repo still uses junit.framework?
Contributor
Author
There was a problem hiding this comment.
Yeah, it hasn't been a high priority to convert it.
chingor13
added a commit
that referenced
this pull request
Jun 3, 2019
This was referenced Jun 3, 2019
clundin25
pushed a commit
to clundin25/google-http-java-client
that referenced
this pull request
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #664
This should fail until we revert #529