Skip to content

feat: make mcp the default protocol#192

Closed
twishabansal wants to merge 8 commits intov20250326from
default-protocol
Closed

feat: make mcp the default protocol#192
twishabansal wants to merge 8 commits intov20250326from
default-protocol

Conversation

@twishabansal
Copy link
Contributor

@twishabansal twishabansal commented Jan 7, 2026

PR 5 for MCP support

PR1: #188
PR1: #189
PR3: #190
PR4: #191

Summary

Updates the SDK configuration to make the Model Context Protocol (MCP) the default communication protocol. This shift marks the transition from the legacy Toolbox-specific protocol to the industry-standard MCP for all client interactions, while still allowing the legacy protocol to be used as a fallback.

Changes

  • Default Protocol Switch: Modified the ToolboxClient initialization logic to default to MCP.
  • Protocol Negotiation: Updated the default handshake behavior to prioritize the highest supported MCP version (currently 2025-06-18) when no specific version is requested by the user.
  • Fallback Logic: Maintained support for the legacy Toolbox protocol for servers that do not yet support MCP, ensuring a smooth transition for existing deployments.
  • Testing:
  • Updated suite-wide test defaults to reflect MCP as the primary protocol.
  • Added verification tests to ensure that the client correctly identifies and switches to the legacy protocol if the MCP handshake fails.

@twishabansal twishabansal changed the base branch from main to v20250618 January 7, 2026 10:47
@twishabansal twishabansal changed the title Default protocol feat: make mcp the default protocol Jan 7, 2026
@twishabansal twishabansal marked this pull request as ready for review January 7, 2026 10:47
@twishabansal twishabansal requested a review from a team January 7, 2026 10:47
url: string,
session?: AxiosInstance | null,
clientHeaders?: ClientHeadersConfig | null,
protocol: Protocol = Protocol.MCP,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a breaking change (for anyone relying on the legacy TOOLBOX protocol behavior implicitly). Can we mark the PR accordingly?

Base automatically changed from v20250618 to v20250326 January 12, 2026 16:32
@twishabansal twishabansal deleted the branch v20250326 January 12, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants