Skip to content

test: fix Mocha patch with undefined timeout error#564

Merged
simonz130 merged 1 commit intomasterfrom
fixMochaTimeout
Mar 8, 2021
Merged

test: fix Mocha patch with undefined timeout error#564
simonz130 merged 1 commit intomasterfrom
fixMochaTimeout

Conversation

@freelerobot
Copy link
Copy Markdown
Contributor

Concurrent with Alex's upstream Mocha fix here
Making the syntax conformant with the rest of the Node tests, which call this.timeout

@freelerobot freelerobot self-assigned this Mar 8, 2021
@freelerobot freelerobot requested review from a team March 8, 2021 21:11
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging-winston API. label Mar 8, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 8, 2021
@freelerobot freelerobot added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Mar 8, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2021

Codecov Report

Merging #564 (1fa7ae3) into master (f2894ca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files           7        7           
  Lines         672      672           
  Branches       49       50    +1     
=======================================
  Hits          636      636           
  Misses         35       35           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2894ca...1fa7ae3. Read the comment docs.

@simonz130 simonz130 merged commit 25eb12b into master Mar 8, 2021
@simonz130 simonz130 deleted the fixMochaTimeout branch March 8, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the googleapis/nodejs-logging-winston API. cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants