This repository was archived by the owner on Feb 18, 2024. It is now read-only.
fix: Register error event handler immediately.#156
Merged
stephenplusplus merged 4 commits intogoogleapis:masterfrom Sep 11, 2018
Merged
fix: Register error event handler immediately.#156stephenplusplus merged 4 commits intogoogleapis:masterfrom
stephenplusplus merged 4 commits intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
ghost
assigned
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 2 2
Lines 34 32 -2
=====================================
- Hits 34 32 -2
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Sep 10, 2018
Contributor
|
@stephenplusplus looks like this just needs to have lint run on it :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62
Currently, when a user calls
streamingRecognize(), we wait to receive incoming data before registering an error handler on the gRPC request stream. This can be an issue if the user doesn't pipe any data until the request deadline is exceeded, resulting in a thrown error. Now, the error will be returned to the user's error handler.