docs: Revise update_table_expiration sample#1457
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
tswast
left a comment
There was a problem hiding this comment.
Looks good! But let's update docs/snippets.py with a comment that we should delete the duplicate sample there once we update cloud.google.com.
|
@thejaredchapman I think we might want to rebase this just so we can fixup the CLA check. Would love to see the commit for #1516 as part of this PR instead of as a second PR, too. |
|
Manually applied the edit This didn't work, ha — someone will need to click the "request exception" link in the CLA checker log. |
494f9b7 to
deff4ad
Compare
|
I've squashed all commits and re-pushed. I believe that should resolve the CLA issue. |
New version of this sample added in #1457 and migrated to in the docs in internal change 570781706.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Towards #790 🦕