Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

This PR renames pipeline expressions to match new naming spec:

  • FilterCondition->BooleanExpr
  • ExprWithAlias->AliasedExpr
  • eq, neq, gt, lt, gte, lte -> equal, not_equal, greater_than, less_than, greater_than_or_equal, less_than_or_equal
  • if->conditional
  • min, max -> minimum, maximum
  • logical_min, logical_max-> logical_minimum, logical_maximum

Also used this as a chance to do some refactoring, removing unnecessary code duplication for easier scaling in the future

@daniel-sanche daniel-sanche requested review from a team as code owners October 21, 2025 03:08
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Oct 21, 2025
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Oct 21, 2025
@daniel-sanche daniel-sanche changed the title fix: update pipeline expressions feat: update pipeline expressions Oct 21, 2025
@daniel-sanche daniel-sanche changed the title feat: update pipeline expressions chore: update and refactor pipeline expressions Oct 21, 2025
@daniel-sanche daniel-sanche assigned bhshkh and unassigned ehsannas Oct 21, 2025
@daniel-sanche daniel-sanche merged commit cd578c1 into pipeline_queries_approved Oct 22, 2025
4 of 7 checks passed
@daniel-sanche daniel-sanche deleted the pipeline_queries_fixed branch October 22, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants