Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Oct 25, 2025

Adds remaining pipeline expressions

@daniel-sanche daniel-sanche requested review from a team as code owners October 25, 2025 00:11
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Oct 25, 2025
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Oct 25, 2025
@ehsannas ehsannas removed their assignment Oct 28, 2025
Copy link

@bhshkh bhshkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Overall LGTM.


@expose_as_static
def map_remove(self, key: str | Constant[str]) -> "Expr":
"""Remove a key from a the map produced by evaluating this expression.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Remove a key from a the map produced by evaluating this expression.
"""Remove a key from the map produced by evaluating this expression.

>>> Field.of("address").map_remove("city")
Args:
key: The key to ewmove in the map.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
key: The key to ewmove in the map.
key: The key to remove in the map.

>>> Expr.array(["bar", Field.of("baz")])
Args:
elements: THe input list to evaluate in the expression
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elements: THe input list to evaluate in the expression
elements: The input list to evaluate in the expression

>>> Expr.map({"foo": "bar", "baz": Field.of("baz")})
Args:
elements: THe input dict to evaluate in the expression
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
elements: THe input dict to evaluate in the expression
elements: The input dict to evaluate in the expression

@daniel-sanche
Copy link
Contributor Author

Thanks, good catches!

@daniel-sanche daniel-sanche merged commit 643f014 into pipeline_queries_approved Oct 29, 2025
4 checks passed
@daniel-sanche daniel-sanche deleted the pipeline_queries_new_exprs branch October 29, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants