Skip to content

chore: Pipeline queries cleanup #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
daniel-sanche merged 41 commits into from
Oct 30, 2025
Merged

chore: Pipeline queries cleanup #1118

daniel-sanche merged 41 commits into from
Oct 30, 2025

Conversation

@daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Oct 28, 2025 •
edited
Loading

  • Removed AliasedAggregate in favor of the generic AliasedExpr[AggregateFunction]
  • Renamed Expr to Expression
  • Renamed GenericStage to RawStage
  • made pipeline_stages a public file (i.e. removed _ prefix)

@daniel-sanche
fixed tests
54c4f6e
@daniel-sanche
added vector expressions
107e412
@daniel-sanche
added new math expressions
a0c36ca
@daniel-sanche
added string manipulation expressions
dcd6af1
@daniel-sanche
added not_nan, not_null, and is_absent
71308dc
@daniel-sanche
added new Array type
0260014
@daniel-sanche
added map and related expressions
1b69435
@daniel-sanche
remove dict and list from constant types
be749e0
@daniel-sanche
Fixed lint
789f29c
@daniel-sanche
added count_if and count_distinct
64be10d
@daniel-sanche
added misc expressions
5d4f878
@daniel-sanche
added error functions
6d6c57f
@daniel-sanche
fixed lint
f1690d8
@daniel-sanche
removed AliasedAggregate in favor of generics
559ad80
@daniel-sanche
improved e2e tests
86ad143
@daniel-sanche
fixed broken stages
f2697ca
@daniel-sanche
added options to generic stage
d18e1f9
@daniel-sanche
fixed unit tests
68b9eff
@daniel-sanche
ran blacken
9b2cc6b
@daniel-sanche
broke out aggregates
3ebdb13
@daniel-sanche
broke up test file
a951789
@daniel-sanche
removed duplicates
1d48d4d
@daniel-sanche
added math file
390ea72
@daniel-sanche
renamed tests
7c2f41f
@daniel-sanche
include test file in test name
41ff06d
@daniel-sanche
fixed lint
d1dc233
@daniel-sanche
broke out tests into multiple yaml files
ca2caa9
@daniel-sanche
fixed static function access
7425832
@daniel-sanche
ignore upgrade warning
086c3af
@daniel-sanche
renamed Expr to Expression
ce2fab2
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/python-firestore API. labels Oct 28, 2025
@daniel-sanche daniel-sanche changed the title chore: Pipeline queries cleanup [DRAFT] chore: Pipeline queries cleanup Oct 28, 2025
@daniel-sanche daniel-sanche changed the title [DRAFT] chore: Pipeline queries cleanup chore: Pipeline queries cleanup Oct 29, 2025
@daniel-sanche daniel-sanche marked this pull request as ready for review October 29, 2025 21:31
@daniel-sanche daniel-sanche requested review from a team as code owners October 29, 2025 21:31
Base automatically changed from pipeline_queries_improve_tests to pipeline_queries_approved October 30, 2025 19:28
@daniel-sanche daniel-sanche assigned bhshkh and unassigned ehsannas Oct 30, 2025
@daniel-sanche daniel-sanche merged commit b5b0bd7 into pipeline_queries_approved Oct 30, 2025
7 checks passed
@daniel-sanche daniel-sanche deleted the pipeline_queries_cleanup branch October 30, 2025 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhshkh bhshkh bhshkh approved these changes

Assignees

@bhshkh bhshkh

Labels

api: firestore Issues related to the googleapis/python-firestore API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-sanche @bhshkh @ehsannas