-
Notifications
You must be signed in to change notification settings - Fork 47
Backdrop generation #2671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: issue-1455-assets-gen
Are you sure you want to change the base?
Backdrop generation #2671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request implements backdrop generation functionality for the SPX GUI, closing issues #2591, #2659, and #2682. The implementation refactors the backdrop generation flow to match the sprite generation pattern, introducing a multi-step generation process with image selection and preview capabilities.
Key changes include:
- Refactored backdrop generation model to support batch image generation (4 images at once) and user selection
- Created reusable UI components (ImageSelector, ImagePreview, LayoutWithPreview) shared between sprite and backdrop generation
- Integrated backdrop generation into the asset library modal with a unified user experience
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
spx-gui/src/models/gen/backdrop-gen.ts |
Refactored to use Task-based batch image generation and added image selection state management |
spx-gui/src/models/gen/backdrop-gen.test.ts |
Updated tests to reflect new batch generation API |
spx-gui/src/models/gen/sprite-gen.ts |
Added name getter/setter for consistency with backdrop generation |
spx-gui/src/apis/aigc.ts |
Removed deprecated genBackdropImage and untilTaskCompleted helper functions |
spx-gui/src/components/asset/library/AssetLibraryModal.vue |
Integrated backdrop generation with finish handling and modal size adjustments |
spx-gui/src/components/asset/gen/backdrop/* |
Complete rewrite of backdrop generation UI components with image selection and preview |
spx-gui/src/components/asset/gen/sprite/* |
Refactored to use shared ImageSelector and LayoutWithPreview components |
spx-gui/src/components/asset/gen/common/* |
Created reusable components for image selection, preview, and responsive layouts |
spx-gui/src/components/ui/modal/UIFormModal.vue |
Added flex layout styling for better content positioning |
spx-gui/src/components/asset/index.ts |
Removed unused useBackdropGenModal export and BackdropGenModal import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </UIBlockItem> | ||
| <main class="backdrop-gen"> | ||
| <LayoutWithPreview :has-preview="gen.image != null"> | ||
| <BackdropSettingInput :gen="gen" :disabled="handleSubmit.isLoading.value" /> |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The disabled prop is passed to BackdropSettingInput in line 38 but is not defined in the component's props interface. This prop is not being used within the component and should either be removed from the parent call or added to the props definition.
| <BackdropSettingInput :gen="gen" :disabled="handleSubmit.isLoading.value" /> | |
| <BackdropSettingInput :gen="gen" /> |
close #2591, #2659, #2682.