Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 70.90% 71.11% +0.20%
==========================================
Files 86 86
Lines 15108 15062 -46
==========================================
- Hits 10713 10712 -1
+ Misses 3341 3295 -46
- Partials 1054 1055 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the playground data loading mechanism by replacing MySQL dump file processing with binary dump format. The key change extracts the restore logic into a public Restore() method and switches from parsing MySQL dumps to directly importing binary dumps.
- Extracted restoration logic from the HTTP handler into a reusable public
Restore()method - Removed MySQL-to-SQLite conversion using AWK script and related dependencies
- Updated playground mode to download binary dump files instead of MySQL dumps
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| master/rest.go | Refactored restore function by extracting core logic into public Restore() method that accepts io.ReadCloser |
| go.mod | Removed github.com/benhoyt/goawk dependency (no longer needed for MySQL conversion) |
| go.sum | Removed checksums for benhoyt/goawk package |
| config/config_test.go | Updated test to use embedded ConfigTOML instead of reading from file |
| config/config.go | Added //go:embed directive to embed config.toml as ConfigTOML variable |
| cmd/gorse-master/main.go | Removed unused --managed flag |
| cmd/gorse-worker/main.go | Removed unused --managed flag |
| cmd/gorse-in-one/mysql2sqlite | Deleted AWK script for MySQL to SQLite conversion |
| cmd/gorse-in-one/main.go | Simplified playground initialization to use binary dump format and call Restore() method |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
No description provided.