Skip to content

Add last updated timestamp to feedback#1114

Merged
zhenghaoz merged 4 commits intomasterfrom
update
Dec 3, 2025
Merged

Add last updated timestamp to feedback#1114
zhenghaoz merged 4 commits intomasterfrom
update

Conversation

@zhenghaoz
Copy link
Collaborator

No description provided.

@zhenghaoz zhenghaoz requested a review from Copilot December 3, 2025 12:38
@zhenghaoz zhenghaoz changed the title Add updated timestamp to feedback Add last updated timestamp to feedback Dec 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds an Updated timestamp field to feedback records across the entire codebase to track when feedback was last modified, complementing the existing Timestamp field that tracks the initial creation time.

Key Changes:

  • Added Updated field to the Feedback struct and database schemas across all supported databases (MySQL, PostgreSQL, SQLite, ClickHouse, MongoDB)
  • Implemented proper aggregation logic: Timestamp uses MIN/LEAST (earliest), Updated uses MAX/GREATEST (latest)
  • Updated protocol buffer definitions and regenerated code with newer protoc versions (v6.33.1)

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
storage/data/database.go Added Updated field to the core Feedback struct definition
storage/data/sql.go Added Updated column to all SQL database schemas (MySQL, PostgreSQL, SQLite, ClickHouse) with appropriate aggregation functions and query updates
storage/data/mongodb.go Added Updated field handling with $max operator for MongoDB upsert operations
storage/data/proxy.go Updated proxy server and client to include Updated field in protobuf conversions
storage/data/database_test.go Updated test expectations to include Updated field and restructured feedback initialization to use explicit field names
server/rest_test.go Updated REST API test expectations to include Updated field in JSON responses
protocol/protocol.proto Added updated field (field number 8) to the Feedback message
protocol/protocol.pb.go Regenerated with protoc-gen-go v1.36.10 and protoc v6.33.1, includes structural improvements
protocol/protocol_grpc.pb.go Regenerated with protoc-gen-go-grpc v1.6.0, includes typo fixes
protocol/data_store.pb.go Regenerated with updated protoc version v6.33.1
protocol/data_store_grpc.pb.go Regenerated with protoc-gen-go-grpc v1.6.0, includes typo fixes
protocol/cache_store.pb.go Regenerated with updated protoc version v6.33.1
protocol/cache_store_grpc.pb.go Regenerated with protoc-gen-go-grpc v1.6.0, includes typo fixes
protocol/encoding.pb.go Regenerated with protoc-gen-go v1.36.10 and protoc v6.33.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.60%. Comparing base (fec9318) to head (c434361).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1114      +/-   ##
==========================================
+ Coverage   71.55%   71.60%   +0.04%     
==========================================
  Files          85       85              
  Lines       14983    15009      +26     
==========================================
+ Hits        10721    10747      +26     
  Misses       3204     3204              
  Partials     1058     1058              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhenghaoz zhenghaoz merged commit d3d47a8 into master Dec 3, 2025
18 checks passed
@zhenghaoz zhenghaoz deleted the update branch December 3, 2025 12:44
@zhenghaoz zhenghaoz restored the update branch December 3, 2025 12:44
@zhenghaoz zhenghaoz deleted the update branch December 3, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants