Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds an Updated timestamp field to feedback records across the entire codebase to track when feedback was last modified, complementing the existing Timestamp field that tracks the initial creation time.
Key Changes:
- Added
Updatedfield to theFeedbackstruct and database schemas across all supported databases (MySQL, PostgreSQL, SQLite, ClickHouse, MongoDB) - Implemented proper aggregation logic:
Timestampuses MIN/LEAST (earliest),Updateduses MAX/GREATEST (latest) - Updated protocol buffer definitions and regenerated code with newer protoc versions (v6.33.1)
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| storage/data/database.go | Added Updated field to the core Feedback struct definition |
| storage/data/sql.go | Added Updated column to all SQL database schemas (MySQL, PostgreSQL, SQLite, ClickHouse) with appropriate aggregation functions and query updates |
| storage/data/mongodb.go | Added Updated field handling with $max operator for MongoDB upsert operations |
| storage/data/proxy.go | Updated proxy server and client to include Updated field in protobuf conversions |
| storage/data/database_test.go | Updated test expectations to include Updated field and restructured feedback initialization to use explicit field names |
| server/rest_test.go | Updated REST API test expectations to include Updated field in JSON responses |
| protocol/protocol.proto | Added updated field (field number 8) to the Feedback message |
| protocol/protocol.pb.go | Regenerated with protoc-gen-go v1.36.10 and protoc v6.33.1, includes structural improvements |
| protocol/protocol_grpc.pb.go | Regenerated with protoc-gen-go-grpc v1.6.0, includes typo fixes |
| protocol/data_store.pb.go | Regenerated with updated protoc version v6.33.1 |
| protocol/data_store_grpc.pb.go | Regenerated with protoc-gen-go-grpc v1.6.0, includes typo fixes |
| protocol/cache_store.pb.go | Regenerated with updated protoc version v6.33.1 |
| protocol/cache_store_grpc.pb.go | Regenerated with protoc-gen-go-grpc v1.6.0, includes typo fixes |
| protocol/encoding.pb.go | Regenerated with protoc-gen-go v1.36.10 and protoc v6.33.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1114 +/- ##
==========================================
+ Coverage 71.55% 71.60% +0.04%
==========================================
Files 85 85
Lines 14983 15009 +26
==========================================
+ Hits 10721 10747 +26
Misses 3204 3204
Partials 1058 1058 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.