Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1124 +/- ##
==========================================
- Coverage 71.66% 71.58% -0.09%
==========================================
Files 85 86 +1
Lines 15019 15089 +70
==========================================
+ Hits 10763 10801 +38
- Misses 3203 3230 +27
- Partials 1053 1058 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds fit and optimize configuration parameters to the [recommend.ranker] section to provide better control over the click-through rate prediction model training process. The changes align the ranker configuration structure with the existing collaborative filtering configuration.
Key Changes:
- Added
FitPeriod,FitEpoch,OptimizePeriod, andOptimizeTrialsconfiguration fields toRankerConfig - Renamed
RefreshRecommendPeriodtoCacheExpireand removedCheckRecommendPeriodto simplify configuration - Updated the master's fit ticker to use the minimum of collaborative and ranker fit periods
- Modified worker to accept a configurable interval parameter instead of using a hardcoded value
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| config/config.go | Added new RankerConfig fields (FitPeriod, FitEpoch, OptimizePeriod, OptimizeTrials, CacheExpire) and removed old fields (CheckRecommendPeriod, RefreshRecommendPeriod) with defaults |
| config/config.toml | Updated ranker configuration section with new parameters and comments, renamed refresh_recommend_period to cache_expire, removed check_recommend_period |
| config/config_test.go | Updated test assertions to verify new ranker configuration fields including type, cache expire, recommenders, fit period/epoch, and optimize period/trials |
| worker/worker.go | Added interval parameter to NewWorker(), removed dynamic ticker adjustment logic, updated tick condition from >= to <= |
| cmd/gorse-worker/main.go | Added --interval CLI flag with default of 1 minute for worker tick duration |
| worker/pipeline.go | Changed from RefreshRecommendPeriod to CacheExpire when calculating timeout for stale recommendations |
| master/master.go | Updated fit ticker to use minimum of collaborative and ranker fit periods to ensure both models are trained appropriately |
| master/tasks.go | Changed click-through rate optimization from using Collaborative.OptimizeTrials to Ranker.OptimizeTrials |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.