[CI] Support Temurin based JDK pinning#943
Merged
jerboaa merged 1 commit intograalvm:defaultfrom Feb 24, 2026
Merged
Conversation
With this patch it's possible to pin the base JDK version to a specific release. In addition to the generic input value for the 'jdk' key of, say, '21/ga', one can specify a specific Temurin release. For example specifying 'pinnedrelease:jdk-25.0.3%2B2-ea-beta' one would get a base JDK of version 25.0.3+2 EA corresponding to this release: https://github.com/adoptium/temurin25-binaries/releases/tag/jdk-25.0.3%2B2-ea-beta The value before the ':' is important to be exactly 'pinnedrelease'. The value after the ':' denotes the release name. E.g. 'jdk-25.0.3%2B2-ea-beta'.
oracle-contributor-agreement
bot
added
the
OCA Verified
Collaborator
Author
|
Example run with a pinned version is here: https://github.com/jerboaa/graal/actions/runs/22299971510 An example commit to do the pinning was: jerboaa@2bead6f |
Collaborator
Author
|
CI failure on Aarch64, Mandrel 25 is: graalvm/graalvm-community-jdk25u#10 Mandrel IT failures on 23.1 are: Karm/mandrel-integration-tests#400 Q IT Misc3 on Mandrel 23.1 seems infra related. All of them unrelated to this patch. |
zakkak
approved these changes
Feb 24, 2026
Comment on lines
+253
to
+258
| if echo ${{ inputs.jdk }} | grep -q 'pinnedrelease'; then | ||
| pinned_release_token=$(echo ${{ inputs.jdk }} | cut -d':' -f1) | ||
| pinned_release=$(echo ${{ inputs.jdk }} | cut -d':' -f2) | ||
| echo "${pinned_release_token}" | ||
| echo "${pinned_release}" | ||
| if [ "${pinned_release_token}_" == "pinnedrelease_" ] && [ "${pinned_release}_" != "_" ]; then |
Collaborator
There was a problem hiding this comment.
Nitpick:
Suggested change
| if echo ${{ inputs.jdk }} | grep -q 'pinnedrelease'; then | |
| pinned_release_token=$(echo ${{ inputs.jdk }} | cut -d':' -f1) | |
| pinned_release=$(echo ${{ inputs.jdk }} | cut -d':' -f2) | |
| echo "${pinned_release_token}" | |
| echo "${pinned_release}" | |
| if [ "${pinned_release_token}_" == "pinnedrelease_" ] && [ "${pinned_release}_" != "_" ]; then | |
| pinned_release_token=$(echo ${{ inputs.jdk }} | cut -d':' -f1) | |
| echo "${pinned_release_token}" | |
| if [ "${pinned_release_token}_" == "pinnedrelease_" ]; then | |
| pinned_release=$(echo ${{ inputs.jdk }} | cut -d':' -f2) | |
| echo "${pinned_release}" | |
| if [ "${pinned_release}_" != "_" ]; then |
Collaborator
Author
There was a problem hiding this comment.
Thanks. I feel the existing approach makes it clearer to say "only do this when pinnedrelease is present. Matter of taste, I guess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch it's possible to pin the base JDK version to a specific release. In addition to the generic input value for the
jdkkey of, say,21/ga, one can specify a specific Temurin release. For example specifyingpinnedrelease:jdk-25.0.3%2B2-ea-betaone would get a base JDK of version25.0.3+2EA corresponding to this release: https://github.com/adoptium/temurin25-binaries/releases/tag/jdk-25.0.3%2B2-ea-betaThe value before the
:is important to be exactlypinnedrelease. The value after the:denotes the release name. E.g.jdk-25.0.3%2B2-ea-beta.Currently this is Linux-only.