Merged
Conversation
Contributor
Author
|
Currently only Blocks is supported(#1212) and you can try this example: |
omerXfaruq
commented
May 9, 2022
| raise HTTPException( | ||
| status_code=status.HTTP_401_UNAUTHORIZED, detail="Not authenticated" | ||
| ) | ||
| class App(FastAPI): |
Contributor
Author
There was a problem hiding this comment.
No functional change here, just tidied things a little bit into OOP.
1 task
- add async function support to Blocks
d2e4654 to
204eb45
Compare
- resolve conflicts
0daf25a to
bdf58b6
Compare
- add error to Interface for async functions
abidlabs
approved these changes
May 11, 2022
Member
|
Looking great @farukozderim! I would only that we add a test in |
- add test
Contributor
Author
Great idea! |
- add test packages
- add test packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #727
This took some time to correctly work on Interface, it seems lambda functions are always wicked :D