Merged
Conversation
|
|
||
| </details> | ||
|
|
||
| ## Documentation: |
Contributor
There was a problem hiding this comment.
I thought you shipped Javadoc. Or not?
Contributor
Author
There was a problem hiding this comment.
Could you rephrase please? I am unable to understand
|
|
||
| ## Documentation: | ||
|
|
||
| - Detailed developer documentation for the implemented functionalities (composite builds, Java Home detection and sending notification on incompatibility, android support). |
Contributor
There was a problem hiding this comment.
Should it have a status line above, as other deliverables?
Contributor
Author
There was a problem hiding this comment.
Are these supposed to be deliverables? I am not sure I thought it was a separate section for additional information.
Contributor
There was a problem hiding this comment.
For me Documentation should be a part of the delivered feature. But, otherwise, it is a separate deliverable and needs a status
| - Usage instructions and troubleshooting steps for the added functionalities. | ||
| - Clear examples and diagrams to enhance understanding. | ||
|
|
||
| ## Unit and Integration Tests: |
Contributor
There was a problem hiding this comment.
Same for the status line
oleg-nenashev
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates: