Merged
Conversation
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1762 +/- ##
==========================================
- Coverage 64.33% 64.31% -0.03%
==========================================
Files 121 121
Lines 9081 9081
==========================================
- Hits 5842 5840 -2
- Misses 2835 2836 +1
- Partials 404 405 +1
|
cyriltovena
approved these changes
Mar 1, 2020
Contributor
cyriltovena
left a comment
cyriltovena
left a comment
There was a problem hiding this comment.
hey thank you for that ! Awesome job ! And welcome 😉
Member
Author
|
@cyriltovena Thank you for the quick review! :) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1762 +/- ##
==========================================
- Coverage 64.33% 64.31% -0.03%
==========================================
Files 121 121
Lines 9082 9081 -1
==========================================
- Hits 5843 5840 -3
- Misses 2835 2836 +1
- Partials 404 405 +1 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As @cyriltovena explained in #1685,
stretchr/testifyv1.4.0 has a bug inassert.Eventuallythat generates flaky results.This bug was solved by stretchr/testify#869. The latest Testify release contains the fix.
Which issue(s) this PR fixes:
Fixes #1685
Special notes for your reviewer:
I used the Dependency management docs as a guide.
Signed-off-by: Daniel González Lopes danielgonzalezlopes@gmail.com