feat(validation): deprecated iface impl discrepancy#734
Merged
pavelnikolov merged 1 commit intomainfrom Apr 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds schema validation to prevent an implementing object/interface field from being marked @deprecated when the corresponding interface field is not, aligning behavior with graphql-spec PR #1053.
Changes:
- Enforce
@deprecateddirective consistency between interface fields and implementing fields (object and interface implementations). - Add test cases covering allowed and rejected deprecation combinations for interface implementations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/schema/schema.go | Adds validation during interface field implementation checks to reject deprecation on the implementing field when the interface field is not deprecated. |
| internal/schema/schema_test.go | Adds acceptance/rejection test cases to verify the new deprecation consistency rule for objects and interfaces implementing interfaces. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pavelnikolov
force-pushed
the
deprecated-dir-discrepancy
branch
from
f39fd5a to
1ca7d97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementations may not deprecate a field that the interface hasn't deprecated.
Addresses graphql/graphql-spec#1053