feat(mill): add has_adjustable_speed and has_timer capability flags#1109
feat(mill): add has_adjustable_speed and has_timer capability flags#1109silasg wants to merge 1 commit intographefruit:developfrom
Conversation
Add two boolean properties to the Mill model that control whether mill_speed and mill_timer fields are visible in brew forms and detail views. When a selected grinder lacks a capability, the corresponding brew field is hidden regardless of global/preparation settings. - Extend Mill interface and class with has_adjustable_speed, has_timer (default true for backward compatibility, no migration needed) - Add HAS_ADJUSTABLE_SPEED, HAS_TIMER to millFunctionPipe - Wire choosenMill into brew-brewing and brew-detail components - Add checkboxes to mill add/edit/detail views - Add i18n keys for all supported languages - Add unit tests for Mill model and brew-brewing visibility - Fix pre-existing bug: millFunctionPipe used PREPARATION enum for HAS_PHOTOS - Increase mill-add modal breakpoint from 0.35 to 0.5 Note: Non-English translations (ar, el, es, fr, id, it, nl, no, pl, pt, tr, zh) are automated and need review by native speakers.
|
Hey @silasg, |
|
Hi @graphefruit, for that reason I set both fields to I also added a test case for that (see 3fb8060#diff-73160c80b39c50e950f649207d028e17fab44f691e9d0e823476000594e7f2eaR34 ) and tested it manually on my phone -- both seemed to work. I only uncheck the boxes in the form if new grinders are added after the update was rolled out. I thought this is the simplest and most backwards compatible way of introducing the feature. But of course I am happy to change it, in case I missed something. |
How could I miss this, sorry!
No thats fine for me. I'll test it tomorrow and give it a merge afterwards |
Add two boolean properties to the Mill model that control whether mill_speed and mill_timer fields are visible in brew forms and detail views. When a selected grinder lacks a capability, the corresponding brew field is hidden regardless of global/preparation settings.
Notes: