toConfig: allows 'extensionASTNodes' to be undefined#2184
Merged
IvanGoncharov merged 1 commit intographql:masterfrom Sep 17, 2019
Merged
toConfig: allows 'extensionASTNodes' to be undefined#2184IvanGoncharov merged 1 commit intographql:masterfrom
IvanGoncharov merged 1 commit intographql:masterfrom
Conversation
We should have consistent behaviour for all properties returned by `toConfig` and since `extensions` is optional that mean `extensionASTNodes` should also be optional
IvanGoncharov
added
the
PR: breaking change 💥
This was referenced Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should have consistent behaviour for all properties returned by
toConfigand sinceextensionsis optional that meanextensionASTNodesshould also be optional