Introduce astFromValueUntyped and handle object values within astFromValue correctly#4087
Closed
ardatan wants to merge 3 commits intographql:mainfrom
Closed
Introduce astFromValueUntyped and handle object values within astFromValue correctly#4087ardatan wants to merge 3 commits intographql:mainfrom
ardatan wants to merge 3 commits intographql:mainfrom
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @ardatan, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
Contributor
|
I think this should be closed within v17 by #3812 and #4209, so I am going to close this old PR in the name of tidying up, feel free to reopen. See also: #4085 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4085
Closes #4086
This PR introduces a new function called
astFromValueUntypedthat creates an AST without a type.This function is needed because if a custom scalar returns an object type, it needs to be serialized without a type.