Add definition of "selection set" and clarify serial execution examples#1032
Merged
Add definition of "selection set" and clarify serial execution examples#1032
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yaacovCR
approved these changes
Nov 9, 2023
benjie
commented
Nov 27, 2023
Comment on lines
+341
to
+342
| :: A _selection set_ defines an ordered set of selections (fields, fragment | ||
| spreads and inline fragments) against an object, union or interface type. |
Member
Author
There was a problem hiding this comment.
🆕 Definition of selection set.
benjie
commented
Nov 27, 2023
Comment on lines
+399
to
+403
| For example, given the following mutation operation, the root _selection set_ | ||
| must be executed serially: | ||
|
|
||
| ```graphql example | ||
| { | ||
| mutation { |
Contributor
There was a problem hiding this comment.
Perhaps we add the mutation example, and keep the selection set example?
benjie
commented
Nov 27, 2023
| we execute the following _selection set_ serially: | ||
|
|
||
| ```graphql example | ||
| # Note: This is a selection set, not a full document using the query shorthand. |
mjmahone
approved these changes
Dec 7, 2023
Contributor
mjmahone
left a comment
There was a problem hiding this comment.
This seems like a positive editorial change
robrichard
approved these changes
Dec 7, 2023
benjie
commented
Mar 7, 2024
fotoetienne
approved these changes
Mar 7, 2024
Member
Author
|
@Keweiqu I've addressed your feedback, I think? Very good catch! 🙌 |
4 tasks
leebyron
reviewed
Apr 4, 2024
leebyron
reviewed
Apr 4, 2024
|
|
||
| ```graphql example | ||
| { | ||
| mutation ChangeBirthdayAndAddress($newBirthday: String!, $newAddress: String!) { |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples 193 and 194 relate to executing selection sets serially. There has been confusion from readers that think that these examples relate to documents (i.e. they should have the
mutationkeyword) but that is not necessarily the case, for example in future we might enable operations such as:To solve this:
I've also fixed the consistency of the casing of 'selection set'.