P34: implementing field type is either exact match or of covariant type#974
Merged
leebyron merged 2 commits intographql:mainfrom Jan 5, 2023
rivantsov:P34_IntfImplTypeMatch
Merged
P34: implementing field type is either exact match or of covariant type#974leebyron merged 2 commits intographql:mainfrom rivantsov:P34_IntfImplTypeMatch
leebyron merged 2 commits intographql:mainfrom
rivantsov:P34_IntfImplTypeMatch
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mjmahone
approved these changes
Dec 7, 2022
Contributor
mjmahone
left a comment
mjmahone
left a comment
There was a problem hiding this comment.
Yeah this is correct, and just a re-iteration of what we say on object type validation: https://spec.graphql.org/draft/#IsValidImplementation()
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: exact type match is not required for implementing field; might be of covariant type