field merging - field TYPES must not differ#979
field merging - field TYPES must not differ#979leebyron merged 3 commits intographql:mainfrom rivantsov:P13_MergeFieldTypes
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
benjie
left a comment
There was a problem hiding this comment.
This is not true; the field types do not have to be the same, they just have to be compatible. Please read http://spec.graphql.org/draft/#FieldsInSetCanMerge() carefully and consider fields with polymorphic types (unions and interfaces). The text as currently stated in the spec is, however, correct.
so, "scalar values must not differ" - it is correct? which values? we are at early validation stage, we do not have any values yet. I thought it should say something about types; ok, maybe not require the exact same types, then pls help to formulate the proper short phrase describing 'type' requirements |
|
You could change the word "values" to "types" I suppose. |
Co-authored-by: Benjie <benjie@jemjie.com>
Minor correction, Editorial.