Fix reference mistake in subscription execution#994
Merged
leebyron merged 1 commit intographql:mainfrom Jun 6, 2024
Merged
Conversation
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Member
|
There's no EasyCLA on this PR, so I'm going to close and open it again. I agree with this change. |
mjmahone
approved these changes
Jun 6, 2024
Member
|
Hi @Yogu thanks for this fix. Just to summarise the discussion last night: this is indeed the right fix, and the other route of closing the streams (when the user unsubscribes, also (optionally) close the source stream) is covered in the prose above the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a bit confused about MapSourceToResponseEvent in the execution specification for subscriptions. It explains how to map a
sourceStreamto aresponseStream. Instead of specifying the behavior in casesourceStreamcompletes, it talks about what happens whenresponseStreamcompletes, even though there is no way howresponseStreamcould complete on its own.Am I right that the specification part just confused
sourceStreamandresponseStreamhere?Also, why is the operation called
MapSourceToResponseEventwhen it maps event streams? Shouldn't it be calledMapSourceStreamToResponseEventStream?