Merged
Conversation
Leverage synctest to exercise client dial timeout tests instead of the tests sitting idle for the entire timeout. Tests were moved to api and now test against the api.Client directly instead of indirectly via the auth.Client to exercise tests against a fake dialer in the synctest bubble.
831f5eb to
58084c2
Compare
zmb3
approved these changes
Feb 21, 2026
tigrato
approved these changes
Feb 21, 2026
tigrato
approved these changes
Feb 21, 2026
Contributor
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Feb 22, 2026
Leverage synctest to exercise client dial timeout tests instead of the tests sitting idle for the entire timeout. Tests were moved to api and now test against the api.Client directly instead of indirectly via the auth.Client to exercise tests against a fake dialer in the synctest bubble.
rosstimothy
added a commit
that referenced
this pull request
Feb 22, 2026
Leverage synctest to exercise client dial timeout tests instead of the tests sitting idle for the entire timeout. Tests were moved to api and now test against the api.Client directly instead of indirectly via the auth.Client to exercise tests against a fake dialer in the synctest bubble.
rosstimothy
added a commit
that referenced
this pull request
Feb 24, 2026
Leverage synctest to exercise client dial timeout tests instead of the tests sitting idle for the entire timeout. Tests were moved to api and now test against the api.Client directly instead of indirectly via the auth.Client to exercise tests against a fake dialer in the synctest bubble.
rosstimothy
added a commit
that referenced
this pull request
Feb 26, 2026
Leverage synctest to exercise client dial timeout tests instead of the tests sitting idle for the entire timeout. Tests were moved to api and now test against the api.Client directly instead of indirectly via the auth.Client to exercise tests against a fake dialer in the synctest bubble.
rosstimothy
added a commit
that referenced
this pull request
Feb 26, 2026
Leverage synctest to exercise client dial timeout tests instead of the tests sitting idle for the entire timeout. Tests were moved to api and now test against the api.Client directly instead of indirectly via the auth.Client to exercise tests against a fake dialer in the synctest bubble.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 26, 2026
Leverage synctest to exercise client dial timeout tests instead of the tests sitting idle for the entire timeout. Tests were moved to api and now test against the api.Client directly instead of indirectly via the auth.Client to exercise tests against a fake dialer in the synctest bubble.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 27, 2026
Leverage synctest to exercise client dial timeout tests instead of the tests sitting idle for the entire timeout. Tests were moved to api and now test against the api.Client directly instead of indirectly via the auth.Client to exercise tests against a fake dialer in the synctest bubble.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Leverage synctest to exercise client dial timeout tests instead of the tests sitting idle for the entire timeout. Tests were moved to api and now test against the api.Client directly instead of indirectly via the auth.Client to exercise tests against a fake dialer in the synctest bubble.
Comparison of the old and new test