Incorrectly count of minimal quantity of Asset.

[dboissat]

Debug mode

• I have enabled debug mode
• I have read checked the Common Issues page

Describe the bug

The minimal quantity feature for asset is useful for finding out when you are approaching the end of your stock and when you need to buy more.
But currently, the count is incorrect and seems perform only a comparaison between "Deployed" devices versus all devices of the models, without check the "Archived" or "Undeployable" status.

Over the years, we have more "archived" or "undeployable" devices but that we don't want to delete to keep a record.

Reproduction steps

On the demo :

1. List "XPS 13" assets: 5 device are created.

• 1 deployed
• 4 ready to deploy

2. Add minimal quantity to 3 on the model "XPS 13".
3. Change status of 2 devices:

• One to Archived
• One to another "Undeployable" status as "Broken - Not Fixable"

4. Now you have only 2 device "Ready to deploy" but no minimal alert quantity.
5. Change the minimal quantity to 5 on the model "XPS 13"
6. You have "4 remaining".

=> Only "Deployed" status seems used.

Expected behavior

On our side, we consider the "pending" status type as into our stock and the "Deployable" status for device "configured" and ready to be installed. But it's maybe not the more common use.

Solution 1:
The feature count all devices "Deployed" versus "Deployable" and "Pending" and exclude "Undeployable" and "Archived".
We obtain the number of devices in "Pending" or "Deployable" into our stock. Not perfect, but closer to what's needed.

Solution 2:
We have the option to personalize how the feature count into the admin configuration tab with two lists : "Status to included" and "Status to excluded".
So everyone can configure how the alert works to suit their needs.

Screenshots

Snipe-IT Version

v6.3.4 build 13139 (g6f9ba6ede)

Operating System

Linux

Web Server

IDK

PHP Version

8.1.27

Operating System

No response

Browser

No response

Version

No response

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

No response

[welcome]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

[snipe]

In your general settings, do you have the “show archived in lists” box checked or unchecked?

[dboissat]

Hello,
In my instance, yes it's checked.
But on the demo, I tested with the option unchecked and I observed the same behavior.

[Fabris-ahb]

I have the same issue here.

All asset is in used but in assets model I see "Assets" = 29, "Remaining" = 29 or that number is in real at 0 cause all asset is affected.

The min Remaining is calculated like Assets - Min QTY = Remaining.

But Remaining need to be calculate like Deployable - Deployable with affectation = remaining in stock

And Min QTY just need to be setup with a value when a trigger send notification

[dboissat]

Hello,

I haven't followed up on this case for a long time.
I upgraded to the latest release and my problem is still there.

While looking through the code, I found out how you calculated it.
Helpers/Helper.php

foreach ($asset_models as $asset_model){
  $asset = new Asset();
  $total_owned = $asset->where('model_id', '=', $asset_model->id)->count();
  $avail = $asset->where('model_id', '=', $asset_model->id)->whereNull('assigned_to')->count();

You only take it into account if and only if the asset is "assigned_to".
However, in my case, assets can be configured and left on hold for a certain amount of time before being "assigned_to".
Furthermore, an “archived” asset is not considered to be "assigned_to", which distorts the calculation.
An asset may be ‘Archived’ because it is defective, sold, or lost => it is no longer in stock and usable.

I personnaly changed like that :
$avail = $asset->where('model_id', '=', $asset_model->id)->whereIn('status_id', [1] )->count();

Because I need to have information about what is available with this status 1 (which corresponds to what is physically in stock at my premises).
All other statuses are equipment that is either configured and assigned, configured and awaiting assignment, or non-deployable (ceased, lost, defected, etc.).

It would be beneficial to modify this by offering the option to choose which status should be considered in the calculation and allowing users to customise it according to their needs.

[Phil7789]

I would like to second this.

Same applies to the "available" count.

Problem
Let's say I do have 4 assets of a type (model). 2 are deployed and 2 are unavailable for deployment (e.g. in repair). The available count for those assets now shows 2.

Expected behavior
Available count should show 0 if 2 items are deployed and 2 items are not ready for deployment (and therefore shouldn't count towards availability)