EULA is not displayed on "accept item" page.

[oolivero45]

When a user is checking out an item, it is expected that a copy of the category's EULA (or global EULA if the category is set to use that) which they are agreeing to would be displayed on the acceptance page. However, this is not the case.

This appears to be due to an error introduced on lines 995 & 997 of Models/Asset.php:

snipe-it/app/Models/Asset.php

Lines 995 to 997 in 1eae5d1

	if (($this->model->category->eula_text) && ($this->model->category->use_default_eula === 0)) {
	return Helper::parseEscapedMarkedown($this->model->category->eula_text);
	} elseif ($this->model->category->use_default_eula === 1) {

This comparison using a triple equal rather than a double causes the EULA to not be shown. Changing this back to a double equal causes the EULA to appear and behave as expected.

I have been able to reproduce and fix the issue on my own installation, so I will submit a PR shortly with a fix.

[oolivero45]

Adding to this: The scope of this issue appears to be larger than initially thought.

Rather than EULAs simply not being displayed on the acceptance page, it appears that the issue is actually that, due to the error fixed in the associated PR, assets are always never considered to have a EULA associated with them regardless of whether one has been enabled or not. Other affected areas are:

• "Asset checked out" emails - no mention of the EULA in the email.
• Admin checkout screen - the text "This user will be emailed a copy of the EULA" is not displayed.

[snipe]

I'm not able to reproduce this.

[oolivero45]

Here's how it's behaving on my end:

Running Snipe-IT version v8.1.18 build 18876 (g4c6249eb9) on PHP 8.2.28.

I'm happy to assist in any way I can with identifying/reproducing.

[snipe]

Do you have a category EULA or a global EULA that you're expecting to see there?

Edit: Duh, sorry, the screenshots hadn't loaded yet, sorry.

[oolivero45]

I'm starting to suspect the issue is that my server/installation is returning settings as a different type than it should be for some reason - I just ran into another problem, this time with the audit interval being a string when Carbon was expecting an integer. This would make sense to be related as it's also an issue with data types being retrieved from settings.

I'll keep you updated if I find anything else.

[snipe]

Hrm. I'm not even sure how that could happen tbh. @uberbrady - any ideas?

[snipe]

Hey there - any updates on your situation?

[mckaygerhard]

I it seems the button dissapears from mail text, the complete text was not parsed to mail as well.. i'll try to upgrade and debug to help with this

[snipe]

I it seems the button dissapears from mail text

There isn't a button in the mail text, just a link.

[snipe]

@oolivero45 - any updates?

[oolivero45]

No updates as of yet, although I haven't had any time to further investigate yet - will hopefully get some time to properly sit down and poke through it in the next week or two!