Skip to content

Acceptance notification doesn't show admin details and string doesn't work outside English #17653

@swift2512

Description

@swift2512

File:
resources/views/notifications/markdown/asset-acceptance.blade.php

  1. Basically, there are two different strings mashed together to make it 'Checked Out By' ('Checked Our' + 'By') in:
    @if (isset($admin))
    | **{{ trans('general.checked_out').' '.trans('general.by')}}** | {{ $admin }} |
    @endif

I believe this string won't make any sense in majority of languages. (It definitely doesn't make any sense in Lithuanian.)
Why not use general.administrator like in other emails?

@if ($admin)
| **{{ trans('general.administrator') }}** | {{ $admin->present()->fullName() }} |
@endif

  1. 'Checked Out By' field shows name of the user who accepted asset (same as in 'User' field), but not of the person who initiated check-out. (Check-out was initiated by superuser.)
Image

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions