[Bug]: running php artisan snipeit:import --update --item-type User <csvfile> fails to update users

[clamjamfrie]

Snipe-IT Version

v8.3.4 - build 20218 (master)

PHP Version

8.3.6

Composer Version

2.8.9

MySQL/MariaDB version

MariaDB 10.11.13

How did you install Snipe-IT?

Git install

Is this a fresh install or an upgrade?

Upgrade

What happened?

Running php artisan snipeit:import --update --item-type User csvfile.csv fails to update users. No error occurs - looks like it succeeds it just doesn't actually do the update.
New users are added though.
The same csv does update users through the website's import facility though.

This was working until I updated to 8.3.4. It was working in version v8.0.4 - build 17333 (master)

The csv file has the following header:
First Name,Last Name,Email,Username,Company,Department,Location,job title

Regards,

Ian.

What browsers are you seeing the problem on?

No response

Can you reproduce this on the public demo?

N/A

Do you have full multiple company support enabled?

Yes

If you have full multiple company support enabled, do you have location scoping to company enabled?

No

Application log output

php artisan snipeit:import --update --item-type User /base/conf/staff_import_KmqWkk.csv
======= Importing Items from /base/conf/staff_import_KmqWkk.csv =========
Import finished.

Browser console output

Common Issues

• I have searched this repo for existing issues related to my issue (including closed issues)
• My APP_URL is set correctly in my .env file (including http or https and no trailing slash)
• I have searched the official Snipe-IT documentation and have checked the Common Issues documentation (where applicable)
• I have run database migrations (where applicable).
• I have attached screenshots and/or videos of the issue (where applicable)

Code of Conduct

• I agree to follow this project's Code of Conduct

[bzeus]

Checking

[snipe]

How many users are you trying to import?

[clamjamfrie]

The normal import has about 300 users (currently 283) but I have tried with only a single user and in both case it fails to update a pre-existing user's record.

[bzeus]

Bug confirmed. Whether it is one or multiple users, it does not update.

It works through the GUI importer though, without problem.

[ManiacTwister]

I've debugged this because i also experienced the problem while importing users. The problem seems to be caused by User Model validation:

[validationErrors:protected] => Illuminate\Support\MessageBag Object
        (
            [messages:protected] => Array
                (
                    [password] => Array
                        (
                            [0] => The password field is required.
                        )

                )

            [format:protected] => :message
        )

This is caused by commit 2bd68ec - after commenting these lines the users get updated

[snipe]

@ManiacTwister Nice sleuthing. It gets a little wobbly here since CLI has no real way of knowing who a user is. The Web UI does, but CLI cannot know that if you don't pass it a value. I'll see if I can work around that.