[Bug]: PR #17691 has been reverted #18344
Description
Snipe-IT Version
master
PHP Version
8.3.28
Composer Version
2.8.12
MySQL/MariaDB version
MariaDB 10.6.22
How did you install Snipe-IT?
Other
Is this a fresh install or an upgrade?
NA
What happened?
It seem that changes made in my PR #17691 have been reverted by commit 07dbc68, and I think this is an error since I don't see how said commit and my PR are related, but I wanted to make sure instead of re-posting a PR to reapply the change.
Since the code change I proposed was reverted, the bug it was supposed to fix is now unfixed again, and URLs in webhooks aren't properly linking back to Snipe IT's objects.
What browsers are you seeing the problem on?
No response
Can you reproduce this on the public demo?
Yes
Do you have full multiple company support enabled?
Yes
If you have full multiple company support enabled, do you have location scoping to company enabled?
Yes
Application log output
Browser console output
Common Issues
- I have searched this repo for existing issues related to my issue (including closed issues)
- My APP_URL is set correctly in my .env file (including http or https and no trailing slash)
- I have searched the official Snipe-IT documentation and have checked the Common Issues documentation (where applicable)
- I have run database migrations (where applicable).
- I have attached screenshots and/or videos of the issue (where applicable)
Code of Conduct
- I agree to follow this project's Code of Conduct