Skip to content

Fixed #13335: Use the app bind in the ldap auth#13739

Closed
vincent-abel wants to merge 1 commit intogrokability:developfrom
vincent-abel:develop
Closed

Fixed #13335: Use the app bind in the ldap auth#13739
vincent-abel wants to merge 1 commit intogrokability:developfrom
vincent-abel:develop

Conversation

@vincent-abel
Copy link
Copy Markdown

@vincent-abel vincent-abel commented Oct 11, 2023

Description

rebind on app cn to fetch user attributes. so users don't need to have a search / read right only for snipeit.
It's mostly a way to share the "fix"

Fixes #13335

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test logins

Test Configuration:

  • Docker with snipeit 6.1.2

Checklist:

@what-the-diff
Copy link
Copy Markdown

what-the-diff bot commented Oct 11, 2023

PR Summary

  • Modification to Logic for User-LDAP Directory Binding
    The team has enhanced the way our software binds users to an LDAP directory. Previously, there may have been instances where a user was not always properly connected to the appropriate LDAP directory. This update ensures a user is correctly assigned by adding a 'rebind' mode. This acts as a double-check procedure, ensuring our app aligns with the user accounts as expected, enhancing the overall user experience.

@snipe snipe requested a review from uberbrady October 11, 2023 16:44
@snipe
Copy link
Copy Markdown
Member

snipe commented Oct 24, 2023

@uberbrady Can you take a look at this when you get a moment please?

@vincent-abel
Copy link
Copy Markdown
Author

Hi, any news?
Is there something blocking?

@vincent-abel
Copy link
Copy Markdown
Author

@uberbrady @snipe is there something blocking?

@snipe
Copy link
Copy Markdown
Member

snipe commented May 29, 2024

@uberbrady ping - can you review for v7 please? We can resolve the conflicts on our own.

@uberbrady
Copy link
Copy Markdown
Member

I did another implementation for this same fix here: #17832 - does this do the same thing for you?

@vincent-abel
Copy link
Copy Markdown
Author

Seems like it yes
Thx

I did another implementation for this same fix here: #17832 - does this do the same thing for you?

@uberbrady uberbrady closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants