Closed
Conversation
Member
|
@uberbrady Are we still looking to take this? We have conflicts, but only in the build stuff, which shouldn't matter, I wouldn't think |
Member
Author
|
Yes, I'm definitely still interested in this. I'll see if I can get the conflicts resolved, at least. |
Member
Author
|
Yay! After pushing up the build artifacts, the tests seem to pass OK. |
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
…to-smaller-pr Fixed grokability#9413 and rework upload API for bulk and better responses (refactor of grokability#16964)
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Added HasUploads trait and remove uploads method for models
Signed-off-by: snipe <snipe@snipe.net>
…-supplier-to-license-relationship Fixed grokability#8484 - added supplier to license relationship
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
…ction_logs Add escaping to user_agent and remote_ip variables for API results
Signed-off-by: snipe <snipe@snipe.net>
…sh-sorting Fixed grokability#17326 - sorting on dashboard
Signed-off-by: snipe <snipe@snipe.net>
…istory Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
…-add-status-to-id Fixed grokability#17441 - hardware listings "remembered" page numbers between statuses
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
https://www.npmjs.com/package/tableexport.jquery.plugin Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Library upgrades
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
snipe
added a commit
that referenced
this pull request
Jul 28, 2025
Signed-off-by: snipe <snipe@snipe.net>
…to improve_javascript
21 tasks
Member
Author
|
I tried to do a nice merge here and somehow it completely blew up the PR. I ended up re-doing it here: #17487 so I'll close this one :/ |
snipe
added a commit
that referenced
this pull request
Jul 28, 2025
Optimize javascript for smaller files and faster builds (Rebase of #15175)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My main goal here was to get our build-cycle to use
require()statements rather than concatenating files together. This puts us on a path to use Laravel Vite instead of Webpack to generate our assets. This also makes the webpack config file easier to read, and has us making library-level changes more at the snipeit.js level. This process was made much easier by the fact that the bulk of everything we do is powered by jQuery - so once you have a working jQuery object, everything just attaches itself to that.I was able to get rid of the 'stub' bootstrap.js file (that file means "Bootstrapping the JavaScript" - no relation to bootstrap, the CSS framework). I just included the main contents at the top of snipeit.js.
I was able to remove an entire step from the build-cycle, which is a bonus. I also added in SourceMaps, which should make troubleshooting our Javascript much easier when the problem is somewhere within our all.js file.
I could keep going but I didn't want to paint myself into a corner, and this is already a little easier to understand than what we had going before.
I haven't clicked around everything in the app, but I did find places where the new generated all.js file wasn't working, but was able to fix those. I imagine I probably missed some more things. I tried to leave comments in the snipeit.js file to explain what files are being included, and why.
There are some files that get generated that aren't included in
.git- I decided not to add them here, since we tend to build JS/CSS assets before releases, they'll show up again.But this is at least a start.