Allowed setting id on location-select component#17080
Merged
snipe merged 2 commits intogrokability:developfrom Aug 7, 2025
Merged
Allowed setting id on location-select component#17080snipe merged 2 commits intogrokability:developfrom
id on location-select component#17080snipe merged 2 commits intogrokability:developfrom
Conversation
Member
|
Are we sure that won't conflict with any jQuery magic we're doing elsewhere? |
Collaborator
Author
|
I can't think of anything conflicting. This is only allowing the option of passing in a custom |
Collaborator
Author
|
Gentle ping on this one. This is component is only being used in one place so far and these changes only exist to provide future flexibility. |
Member
|
I think I worked around it anyway, so it's not really needed, but it won't hurt, I suppose. |
Yvejen
pushed a commit
to Yvejen/snipe-it
that referenced
this pull request
Nov 19, 2025
…ation-select Allowed setting `id` on location-select component
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows customizing the
idfor thelocation-selectcomponent.So far it is only used on the asset check in page and, since the name is set to
location_id, the id is rendered aslocation_id_location_select. This behavior is still present but now passing something likeid="here"would renderid="here"within the component.